RFR: 8368972: Create implementation of menu bar accessibility component [v4]

Ambarish Rapte arapte at openjdk.org
Thu Oct 9 10:08:25 UTC 2025


On Wed, 8 Oct 2025 20:46:12 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Create the accessibility peer for menu bar component also fix the problem when with the voiceover is on the <Ctrl>-F10 is pressed the name of the selected menu is not announced.
>
> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Cover the case when menu item has children but it does not respond to the accessibilityValue selector;

LGTM, With a minor query. 
I shall re-approve if query results in a change.

modules/javafx.graphics/src/main/native-glass/mac/a11y/JFXMenuItemAccessibility.m line 46:

> 44:         return @"";
> 45:     }
> 46:     return title;

Minor query: Is `return @""` statement required ? Cant' we rely on `return title;` (which would return nil in case) ?

-------------

Marked as reviewed by arapte (Reviewer).

PR Review: https://git.openjdk.org/jfx/pull/1927#pullrequestreview-3318173968
PR Review Comment: https://git.openjdk.org/jfx/pull/1927#discussion_r2416246855


More information about the openjfx-dev mailing list