RFR: 8367578: Additional WebKit 622.1 fixes from WebKitGTK 2.48.7 [v2]
Jay Bhaskar
jbhaskar at openjdk.org
Fri Oct 10 12:07:49 UTC 2025
On Thu, 9 Oct 2025 18:12:46 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional commit since the last revision:
>>
>> adding review comments
>
> modules/javafx.web/src/main/native/Source/WebCore/Modules/compression/CompressionStreamEncoder.cpp line 91:
>
>> 89: return result != Z_OK && result != Z_STREAM_END && result != Z_BUF_ERROR;
>> 90: #endif
>> 91: return true;
>
> I don't understand this change. It didn't come from upstream, since this file wasn't changed in the upstream code between 2.48.5 and 2.48.7?
>
> I'm surprised that removing this return statement didn't cause a compilation failure for the `PLATFORM(JAVA)` case (i.e., for JavaFX), but somehow doesn't. Possibly it is just being treated as a warning rather than an error.
>
> I recommend to revert this change (i.e., revert this file).
we do not use OptionsGTK.cmake, but i think it missed , added to be in sync
return true; is added now
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1933#discussion_r2419737806
More information about the openjfx-dev
mailing list