RFR: 8361286: Allow enabling of background loading for images loaded from an InputStream [v5]

John Hendrikx jhendrikx at openjdk.org
Fri Oct 10 15:04:28 UTC 2025


On Tue, 30 Sep 2025 16:17:28 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> John Hendrikx has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Clarify documentation with regards to stream closing
>
> modules/javafx.graphics/src/main/java/javafx/scene/image/Image.java line 625:
> 
>> 623:      * <p>
>> 624:      * The image loading is performed immediately and is completed after this
>> 625:      * constructor returns.
> 
> I think it would it be clearer to say that it is completed "when" this constructor returns, as you do in a couple other places. As it is "after ... returns" could mislead someone into thinking that the operation might not be complete upon return.

You're right, that is clearer, fixed.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1875#discussion_r2420663526


More information about the openjfx-dev mailing list