RFR: 8364547: Window size may be incorrect when constrained to min or max [v2]

Martin Fox mfox at openjdk.org
Sat Oct 11 06:52:19 UTC 2025


On Fri, 10 Oct 2025 14:59:09 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>>> Could this lead to two resize commands in some cases?
>> 
>> Yes, I was trying not to be too clever with my checks. I figured if the second notification wasn't necessary it would be benign. At the very least it won't trigger invalidation of the window's width and height properties.
>> 
>> I will tighten this up since I have to tweak the code a bit anyway. I just verified that on Windows you can alter the size of a maximized window and the OS will keep it in the MAXIMIZED state (as it resizes glass calls notifyResize with WindowEvent.MAXIMIZED). This PR can kick the window out of the MAXIMIZED or MINIMIZED state incorrectly. Unfortunately it puts the window in the wrong internal state without updating the maximized or iconified properties so it's not easy to write a test to detect this.
>
> This is pending work from you, right? I'll put it back on my review queue once you make the changes you mentioned above.

I've made the changes. It should be ready for review.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1870#discussion_r2422543900


More information about the openjfx-dev mailing list