RFR: 8365635: Add MOUSE_DRAG_DONE event type [v3]
Michael Strauß
mstrauss at openjdk.org
Sat Oct 11 12:10:24 UTC 2025
On Fri, 10 Oct 2025 22:46:36 GMT, Nir Lisker <nlisker at openjdk.org> wrote:
>> Adds `MOUSE_DRAG_DONE` event type to `MouseDragEvent` and appropriate handlers.
>
> Nir Lisker has updated the pull request incrementally with one additional commit since the last revision:
>
> Changed to HTML comments
modules/javafx.graphics/src/main/java/javafx/scene/input/MouseDragEvent.java line 132:
> 130: /**
> 131: * This event occurs when the gesture ends. It is delivered exactly once to the source node/scene, and is always the
> 132: * last event in the full press-drag-release process. It is delivered even when the mouse is outside the application.
1. `It is delivered exactly once to the source node/scene`: you could probably remove `/scene`, it is implied by the way events work. Maybe be a bit more precise: `It is delivered exactly once to the node on which the press-drag-release gesture was started`.
2. `outside the application` is a bit vague, as applications don't have a spatial extent. How about: `It is delivered even when the mouse was released outside of the window`.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1873#discussion_r2422767965
More information about the openjfx-dev
mailing list