RFR: 8365635: Add MOUSE_DRAG_DONE event type [v3]

Michael Strauß mstrauss at openjdk.org
Sat Oct 11 13:51:22 UTC 2025


On Sat, 11 Oct 2025 13:12:47 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> modules/javafx.graphics/src/main/java/javafx/scene/input/MouseDragEvent.java line 132:
>> 
>>> 130:     /**
>>> 131:      * This event occurs when the gesture ends. It is delivered exactly once to the source node/scene, and is always the
>>> 132:      * last event in the full press-drag-release process. It is delivered even when the mouse is outside the application.
>> 
>> 1. `It is delivered exactly once to the source node/scene`: you could probably remove `/scene`, it is implied by the way events work. Maybe be a bit more precise: `It is delivered exactly once to the node on which the press-drag-release gesture was started`.
>> 2. `outside the application` is a bit vague, as applications don't have a spatial extent. How about: `It is delivered even when the mouse was released outside of the window`.
>
> 1. I'm not sure why scene is implied from node considering it's not a node - the language often used is "gesture source". This is also why I don't understand why remove that term and replace it with its meaning.
> 2. Changed.

Why do you use the term "node" then, if it shouldn't mean `Node`?

`Scene` is always implied, as you can't receive input events for event targets that are not part of a scene graph.

Maybe use "gesture source", if that's what is often used here. The wording "node/scene" throws me off: is it one, or the other, or both? It's unnecessarily vague.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1873#discussion_r2422857318


More information about the openjfx-dev mailing list