RFR: 8359599: Calling refresh() for all virtualized controls recreates all cells instead of refreshing the cells [v3]
Marius Hanl
mhanl at openjdk.org
Wed Oct 15 13:58:58 UTC 2025
On Mon, 13 Oct 2025 16:30:14 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> I would rather explain it at the top level, since it is the class the app devs use, instead of referring to some part of the skin in another package.
>>
>> And what if the control uses a custom skin that is not based on the `VirtualFlow`?
>>
>> In fact, the public method in this Control is the normative one, so it must define the expected behavior for all the implementors to follow.
>
>> In fact, the public method in this Control is the normative one, so it must define the expected behavior for all the implementors to follow.
>
> You're absolutely right.
> And what if the control uses a custom skin that is not based on the `VirtualFlow`?
But that can also be used against using the description from `VirtualFlow`. Right now, I would insist to not add any more details, as the rebuild implementation may change later on.
Right now, we remove and add them to the viewport, but this is not really needed. What we want to achieve is that `updateItem` is called, and this way ensures that. But there are other, better and faster ways to do so. Something I might revisit at one point in the future.
And since the `In other words` explains why this useful, I think we are good here.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1830#discussion_r2432669082
More information about the openjfx-dev
mailing list