RFR: 8370253: CodeArea: NPE on copy

Kevin Rushforth kcr at openjdk.org
Thu Oct 23 17:11:18 UTC 2025


On Tue, 21 Oct 2025 15:38:38 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

> Fixes a missing `null` check in `CodeArea.copy()` when the `syntaxHighlighter` property is set. 
> 
> Also
> - made sure other callers check for null
> - removed dead code

LGTM. The newly added `copyWithSyntaxDecorator` test fails without the fix and passes with the fix.

This is a simple enough fix that a single reviewer is sufficient.

-------------

Marked as reviewed by kcr (Lead).

PR Review: https://git.openjdk.org/jfx/pull/1942#pullrequestreview-3371283615
PR Comment: https://git.openjdk.org/jfx/pull/1942#issuecomment-3438150686


More information about the openjfx-dev mailing list