RFR: 8370632: Additional libxslt 1.1.43 fixes

Kevin Rushforth kcr at openjdk.org
Mon Oct 27 13:03:45 UTC 2025


On Mon, 27 Oct 2025 11:06:54 GMT, Hima Bindu Meda <hmeda at openjdk.org> wrote:

> Additional fixes for libxslt 1.1.43. Verified build and sanity.

LGTM. The indentation looks a little off in a couple places, so you might want to check it. I'll reapprove if you make any changes.

modules/javafx.web/src/main/native/Source/ThirdParty/libxslt/src/libxslt/transform.c line 2604:

> 2602:             * Cleanup temporary tree fragments.
> 2603:             */
> 2604:                     if (oldLocalFragmentTop != ctxt->localRVTList)

Indentation is off.

modules/javafx.web/src/main/native/Source/ThirdParty/libxslt/src/libxslt/transform.c line 5329:

> 5327:     * "select" expression.
> 5328:     */
> 5329:         if (oldLocalFragmentTop != ctxt->localRVTList)

Indentation

-------------

Marked as reviewed by kcr (Lead).

PR Review: https://git.openjdk.org/jfx/pull/1949#pullrequestreview-3383279562
PR Review Comment: https://git.openjdk.org/jfx/pull/1949#discussion_r2465504756
PR Review Comment: https://git.openjdk.org/jfx/pull/1949#discussion_r2465506067


More information about the openjfx-dev mailing list