RFR: 8368478: RichTextArea: add IME support [v2]
Kevin Rushforth
kcr at openjdk.org
Wed Oct 29 19:28:45 UTC 2025
On Wed, 29 Oct 2025 18:12:36 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
>> Adds Input Method Editor (IME) support to `RichTextArea`/`CodeArea`.
>>
>> Tested on macOS and Windows 11 with Japanese and Chinese (pinyin) input methods.
>> Please test this on Linux, even though there is no platform-specific code in this PR (should work the same way it does in `TextArea`/`TextField`)
>>
>> For testing, one can use the updated Monkey Tester
>> https://github.com/andy-goryachev-oracle/MonkeyTest
>> (optionally enable IME events in stdout with Logging -> IME Monitor)
>
> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision:
>
> - review comments
> - Merge branch 'master' into 8368478.ime
> - test
> - accessor
> - cleanup
> - whitespace
> - Merge remote-tracking branch 'origin/master' into 8368478.ime
> - ime object
> - ime location
> - ime works
> - ... and 1 more: https://git.openjdk.org/jfx/compare/c7946b30...3bb8d850
LGTM. Tested on Windows (in addition to macOS which I tested earlier).
I left a follow-up comment about your added TODOs. I'll reapprove if you make any changes.
-------------
Marked as reviewed by kcr (Lead).
PR Review: https://git.openjdk.org/jfx/pull/1938#pullrequestreview-3395713832
More information about the openjfx-dev
mailing list