RFR: 8368478: RichTextArea: add IME support [v2]

[Kevin Rushforth]

On Wed, 29 Oct 2025 17:47:48 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> modules/jfx.incubator.richtext/src/main/java/com/sun/jfx/incubator/scene/control/richtext/TextCell.java line 264:
>> 
>>> 262:             dy = f.snappedTopInset();
>>> 263: 
>>> 264:             p = f.rangeShape(start, end); // TODO new api, no null
>> 
>> Is this "TODO" really related to IME? If not, I recommend removing it.
>
> this code predates [JDK-8357594](https://bugs.openjdk.org/browse/JDK-8357594)
> Additional geometry-based Text/TextFlow APIs.  I am planning to migrate to the new API in a follow-up.
> 
> Created https://bugs.openjdk.org/browse/JDK-8370902

Thanks for filing the RFE. Since you aren't otherwise modifying this method in this PR, adding a random TODO like this seems like an unrelated change. Now if you meant to also add this comment to line 232 (the call to `f.getUnderlineShape(start, end)` that you added above), then I could see also adding a reminder here as well.

So I recommend either adding a similar comment on line 232, or removing the unrelated TODOs.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1938#discussion_r2475045338