RFR: 8366201: RichTextArea: remove allowUndo parameter [v3]
Kevin Rushforth
kcr at openjdk.org
Thu Oct 30 12:58:56 UTC 2025
On Thu, 30 Oct 2025 12:23:18 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision:
>>
>> - review comments
>> - Merge remote-tracking branch 'origin/master' into 8366201.allow.undo
>> - undo redo enabled logic
>> - cleanup
>> - cleanup
>> - removed allow undo parameter
>> - nl
>> - test
>> - append insert text
>> - tests
>> - ... and 1 more: https://git.openjdk.org/jfx/compare/d067a608...ffe6894c
>
> modules/jfx.incubator.richtext/src/test/java/test/jfx/incubator/scene/control/richtext/RichTextAreaTest.java line 796:
>
>> 794: assertTrue(control.isUndoable());
>> 795: control.setUndoRedoEnabled(false);
>> 796: assertFalse(control.isUndoable());
>
> To check that the stack is actually cleared, you might want to re-enable undoRedo, append text, undo, check for "23", undo again, check that it is still "23".
GitHub is doing something odd here. In the Conversation view, it looks like I added this comment below line 772 (I didn't). If you look in the "Files" view (the diffs), you will see that I added it below line 796.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1941#discussion_r2477993144
More information about the openjfx-dev
mailing list