RFR: 8366201: RichTextArea: remove allowUndo parameter [v4]

Kevin Rushforth kcr at openjdk.org
Thu Oct 30 15:35:06 UTC 2025


On Thu, 30 Oct 2025 15:22:14 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Original user feedback (see https://mail.openjdk.org/pipermail/openjfx-discuss/2025-August/000267.html ) called for adding an `allowUndo` parameter to `applyStyle()` and `setStyle()` methods similarly to `replaceText()`.
>> 
>> Upon further analysis, the `allowUndo` parameter was a mistake: allowing the application code to disable creating undo/redo entries messes up the internal undo/redo stack.
>> There is an internal need (`UndoableChange`), but it should not be exposed via public API.
>> 
>> This PR also adds `isUndoRedoEnabled()` and `setUndoRedoEnabled()` to the `StyledTextModel`, as well as its forwarding aliases to `RichTextArea` to allow for the application to disable undo/redo temporarily, for example, when building a document from multiple segments.
>> 
>> WARNING this is an incompatible change, permitted because of the incubator.
>> 
>> There remains a possible issue with currently unlimited size of the undo/redo stack - perhaps we should limit its depth to maybe 100-200 entries, see https://bugs.openjdk.org/browse/JDK-8370447 .
>
> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review comments

Looks good apart from one stray "the" in one of the methods.

modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/CodeArea.java line 440:

> 438:     /**
> 439:      * Replaces text in this CodeArea.
> 440:      * It creates an undo/redo entry if the

Remove the stray `the` at the end of this line.

-------------

PR Review: https://git.openjdk.org/jfx/pull/1941#pullrequestreview-3400252816
PR Review Comment: https://git.openjdk.org/jfx/pull/1941#discussion_r2478557155


More information about the openjfx-dev mailing list