RFR: 8366201: RichTextArea: remove allowUndo parameter [v6]

Kevin Rushforth kcr at openjdk.org
Thu Oct 30 22:36:25 UTC 2025


On Thu, 30 Oct 2025 22:23:30 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

> While reviewing the CSR I found 3 more places where you missed adding `if {@link #isUndoRedoEnabled()} returns {@code true}` to a method that creates an undo/redo entry.

As discussed offline, another option is to remove all mention of "creates an undo/redo entry" from the RichTextArea methods, since those all forward it to the model, and it is the model that creates and tracks the undo/redo entries.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1941#issuecomment-3470492447


More information about the openjfx-dev mailing list