RFR: 8364547: Window size may be incorrect when constrained to min or max [v2]
Kevin Rushforth
kcr at openjdk.org
Fri Oct 31 18:48:24 UTC 2025
On Mon, 18 Aug 2025 17:23:43 GMT, Martin Fox <mfox at openjdk.org> wrote:
>> When changing the width and height of a window the platform code is responsible for enforcing the min and max size constraints. If the final width and height don't match the width and height passed into setBounds the platform needs to call notifyResize to correct the window's properties. This happens naturally if the window size actually changes since that will trigger the OS to send size change notifications. If the platform window size doesn't change the OS notifications won't trigger. We need to catch that case and send notifyResize anyway.
>>
>> This PR does this for Mac and Windows. Linux is being handled in PR #1789 which also includes the system tests for these bugs.
>
> Martin Fox has updated the pull request incrementally with one additional commit since the last revision:
>
> Remove double notifications, keep window min/max/normal state unchanged.
A primary reason for merging master in a PR whose source branch is out of date is to catch any problems that might arise due to semantic conflicts. Skara and GitHub do a pretty good job of catching merge conflicts, but there can be semantically conflicting changes even if there are no git merge conflicts.
This is 70 commits behind, so merging master is a good idea. It will trigger a GHA run, which isn't conclusive, but is at least a first pass indicator. If it is a clean merge, there will be no need to re-review.
Having said that, I did my testing using a branch in my repo where I merged in master as of two weeks ago (I always do that when I run CI tests) and didn't see any problems, so if you're confident that there won't be a problem, you can integrate.
-------------
PR Comment: https://git.openjdk.org/jfx/pull/1870#issuecomment-3474436662
More information about the openjfx-dev
mailing list