RFR: 8366201: RichTextArea: remove allowUndo parameter [v7]

Andy Goryachev angorya at openjdk.org
Fri Oct 31 19:58:19 UTC 2025


On Fri, 31 Oct 2025 19:31:05 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   undo/redo javadoc in model only
>
> modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/CodeArea.java line 446:
> 
>> 444:     public final void setText(String text) {
>> 445:         TextPos end = getDocumentEnd();
>> 446:         getModel().replace(null, TextPos.ZERO, end, text);
> 
> The javadoc description for this method still says "an undo event gets created".

this is one place where I do want to mention the undo event.
How about:

     * The caret gets reset to the start of the document, selection gets cleared,
     * and an undo event is created if {@link #isUndoRedoEnabled()} returns {@code true}.


?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1941#discussion_r2482526667


More information about the openjfx-dev mailing list