RFR: 8366201: RichTextArea: remove allowUndo parameter [v9]
Kevin Rushforth
kcr at openjdk.org
Fri Oct 31 21:23:21 UTC 2025
On Fri, 31 Oct 2025 20:18:04 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
>> Original user feedback (see https://mail.openjdk.org/pipermail/openjfx-discuss/2025-August/000267.html ) called for adding an `allowUndo` parameter to `applyStyle()` and `setStyle()` methods similarly to `replaceText()`.
>>
>> Upon further analysis, the `allowUndo` parameter was a mistake: allowing the application code to disable creating undo/redo entries messes up the internal undo/redo stack.
>> There is an internal need (`UndoableChange`), but it should not be exposed via public API.
>>
>> This PR also adds `isUndoRedoEnabled()` and `setUndoRedoEnabled()` to the `StyledTextModel`, as well as its forwarding aliases to `RichTextArea` to allow for the application to disable undo/redo temporarily, for example, when building a document from multiple segments.
>>
>> WARNING this is an incompatible change, permitted because of the incubator.
>>
>> There remains a possible issue with currently unlimited size of the undo/redo stack - perhaps we should limit its depth to maybe 100-200 entries, see https://bugs.openjdk.org/browse/JDK-8370447 .
>
> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
>
> set text
modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/CodeArea.java line 442:
> 440: * <p>
> 441: * The caret gets reset to the start of the document, selection gets cleared,
> 442: * and an undo event is created if {@link #isUndoRedoEnabled()} returns {@code true}.
This is at odd with all the other recent changes you did, where you intentionally removed all such mentions in the control.
Suggestion:
* The caret gets reset to the start of the document and the selection gets cleared.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1941#discussion_r2482703182
More information about the openjfx-dev
mailing list