RFR: 8359154: Intermittent system test failures on macOS

[Kevin Rushforth]

On Fri, 12 Sep 2025 18:31:47 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

> Issue: 
> On MacOS, several tests fail intermittently.
> 
> Fix: 
> - The test TableViewContextMenuSortTest.testContextMenuRequestDoesNotSort() performs a Ctrl + Click test only on MacOS platform.
> - If the Ctrl + Click is avoided, then the test failures are not observed.
> - So this change comments out the part of the test in question.
> - A follow-up ticket is created to investigate/update the test [JDK-8367566](https://bugs.openjdk.org/browse/JDK-8367566)
> 
> Verification:
> 1. Verified the headful test with full run, 12 times. The issue does not occur.
> Without this change, the tests do fail more often.
> 2. @beldenfox shared a way to reproduce the failures, in a comment in JBS ticket : [JDK-8359154](https://bugs.openjdk.org/browse/JDK-8359154)**:** If these 5 tests are run repeatedly TableViewClickOnTroughTest, TableViewContextMenuSortTest, TableViewResizeColumnToFitContentTest, TreeTableViewChangeRootTest, and TreeTableViewResizeColumnToFitContentTest, then the issue could occur in 'n' iterations < 120. 
> With this change, no test failure is observed. Several times, tested 120 iterations.

LGTM with one minor suggestion for the comment. I'll reapprove if you change it.

tests/system/src/test/java/test/robot/javafx/scene/tableview/TableViewContextMenuSortTest.java line 108:

> 106: 
> 107:         /*
> 108:         // This part of test is causing intermittent test failures on MacOS. see: JDK-8359154

Suggestion:

        // Skipped due to JDK-8367566
        // This part of test is causing intermittent test failures on MacOS. see: JDK-8359154


I would add a clear comment at the beginning with the bug ID that is the reason for skipping the test (the new bug you filed, JDK-8367566).

Also, we normally wouldn't list the bug ID of the bug you are fixing (JDK-8359154), but it's OK in this case, since the comment is explaining why we are skipping the test; the whole comment block can be removed when JDK-8367566 is fixed.

-------------

Marked as reviewed by kcr (Lead).

PR Review: https://git.openjdk.org/jfx/pull/1899#pullrequestreview-3218355349
PR Review Comment: https://git.openjdk.org/jfx/pull/1899#discussion_r2345142117