RFR: 8359154: Intermittent system test failures on macOS [v2]
Ambarish Rapte
arapte at openjdk.org
Fri Sep 12 19:14:55 UTC 2025
On Fri, 12 Sep 2025 18:44:54 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> Ambarish Rapte has updated the pull request incrementally with one additional commit since the last revision:
>>
>> update comment
>
> tests/system/src/test/java/test/robot/javafx/scene/tableview/TableViewContextMenuSortTest.java line 108:
>
>> 106:
>> 107: /*
>> 108: // This part of test is causing intermittent test failures on MacOS. see: JDK-8359154
>
> Suggestion:
>
> // Skipped due to JDK-8367566
> // This part of test is causing intermittent test failures on MacOS. see: JDK-8359154
>
>
> I would add a clear comment at the beginning with the bug ID that is the reason for skipping the test (the new bug you filed, JDK-8367566).
>
> Also, we normally wouldn't list the bug ID of the bug you are fixing (JDK-8359154), but it's OK in this case, since the comment is explaining why we are skipping the test; the whole comment block can be removed when JDK-8367566 is fixed.
Thank you for the review.
Updated the comment as guided, please check.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1899#discussion_r2345201110
More information about the openjfx-dev
mailing list