RFR: 8336332: Rework tests to avoid unrelated stderr output [v7]
Andy Goryachev
angorya at openjdk.org
Thu Sep 18 16:29:45 UTC 2025
On Thu, 18 Sep 2025 15:47:23 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
>>
>> cleanup
>
> modules/javafx.base/src/test/java/test/javafx/util/OutputRedirect.java line 141:
>
>> 139:
>> 140: private static Map<String, Integer> toMap(Object... expected) {
>> 141: HashMap<String, Integer> m = new HashMap<>();
>
> Suggestion: Given how they are used, you might consider using a `Set` (which could be created as either a `LinkedHashSet` or `TreeSet`) instead. This would simplify the logic a bit.
No, I need the counts.
JDK has neither `MultiMap`s nor counting sets.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1897#discussion_r2360175846
More information about the openjfx-dev
mailing list