RFR: 8367991: Update RegionBackground tests to use ScreenCaptureTestWatcher utility [v2]

Andy Goryachev angorya at openjdk.org
Fri Sep 19 15:19:09 UTC 2025


On Fri, 19 Sep 2025 10:18:52 GMT, Jayathirth D V <jdv at openjdk.org> wrote:

>> We are seeing very rare intermittent failures in RegionBackgroundFillUITest & RegionBackgroundImageUITest tests in linux. We already have [JDK-8328217](https://bugs.openjdk.org/browse/JDK-8328217) to fix this issue.
>> 
>> To identify the root cause better, we want to capture the test content when it is failing using ScreenCaptureTestWatcher utility.
>> 
>> Since we wan to capture the test window before test stage is cleared. We are now clearing the test stage and next test setup. Initially tried updating this behaviour in `VisualTestBase` itself, but that causes tests like `test.robot.test3d.PointLightIlluminationTest` as it overrides the test setup functions.
>> 
>> This change is tested to make sure ScreenCaptureTestWatcher takes appropriate screen capture on failure and CI full headful test run is green.
>
> Jayathirth D V has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add missing initialization logic

looks good.  left a few minor comments and one suggestion.

tests/system/src/test/java/test/robot/javafx/scene/layout/RegionBackgroundFillUITest.java line 88:

> 86:     @AfterEach
> 87:     public void doTeardown() {
> 88: 

please remove empty line

tests/system/src/test/java/test/robot/javafx/scene/layout/RegionBackgroundImageUITest.java line 80:

> 78:     @AfterEach
> 79:     public void doTeardown() {
> 80: 

please remove empty line

-------------

PR Review: https://git.openjdk.org/jfx/pull/1913#pullrequestreview-3245412612
PR Review Comment: https://git.openjdk.org/jfx/pull/1913#discussion_r2363257728
PR Review Comment: https://git.openjdk.org/jfx/pull/1913#discussion_r2363256635


More information about the openjfx-dev mailing list