RFR: 8368166: Media query should accept multiple rules [v2]
Andy Goryachev
angorya at openjdk.org
Tue Sep 23 16:43:10 UTC 2025
On Mon, 22 Sep 2025 23:52:21 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:
>> Given a media query with more than one rule:
>>
>>
>> @media (prefers-color-scheme: dark) {
>> .foo1 {
>> -fx-background-color: black;
>> }
>> .foo2 {
>> -fx-background-color: white;
>> }
>> }
>>
>>
>> The following CSS parser error is encountered: `Expected RBRACE`
>>
>> The reason for this bug is that the CSS parser mistakenly expects that after the first rule was parsed, the media query should be terminated with a closing curly brace. This is obviously incorrect, the fix is relatively simple.
>
> Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:
>
> emit error when closing curly brace is missing
Marked as reviewed by angorya (Reviewer).
Is this just a matter of initializing the values to [0,0] perhaps?
Regardless, I think the current changes are acceptable. Thanks for clarifications!
-------------
PR Review: https://git.openjdk.org/jfx/pull/1915#pullrequestreview-3258844299
PR Comment: https://git.openjdk.org/jfx/pull/1915#issuecomment-3324796467
More information about the openjfx-dev
mailing list