RFR: 8377185: [iOS] Native code compiler warnings and error building libprism_es2 [v4]
Jose Pereda
jpereda at openjdk.org
Tue Feb 10 09:40:45 UTC 2026
On Tue, 10 Feb 2026 09:04:46 GMT, Johan Vos <jvos at openjdk.org> wrote:
>> Jose Pereda has updated the pull request incrementally with one additional commit since the last revision:
>>
>> remove pointer casting and revert unneeded changes
>
> modules/javafx.graphics/src/main/native-prism-es2/PrismES2Defs.h line 72:
>
>> 70: #include <TargetConditionals.h>
>> 71:
>> 72: #define jlong_to_ptr(value) (intptr_t)(value)
>
> I believe we should be able to use those on IOS as well?
> In any case, it is better to case to a pointer instead of to a long
I removed the unnecessary casting in `IOSWindowSystemInterface.m`, so there is no need to modify `PrismES2Defs.h`.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2064#discussion_r2786862873
More information about the openjfx-dev
mailing list