RFR: 8377427: Reduce substring allocations in Color.web(String, double) [v4]

Andy Goryachev angorya at openjdk.org
Fri Feb 13 21:46:16 UTC 2026


On Fri, 13 Feb 2026 20:40:33 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:

>> Color.web(string, double) parses a color string by creating substrings of the input. These string allocations can be removed.
>> 
>> There are no new tests for the `Color` class, since the existing tests already cover all relevant code paths.
>
> Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comments

I am always impressed by the high quality submissions and the level of discussion from you @mstr2 .

This lgtm - if you decide to explain the source of error in the javadoc I'll re-approve.  (There is one more reviewer needed anyway)

-------------

Marked as reviewed by angorya (Reviewer).

PR Review: https://git.openjdk.org/jfx/pull/2069#pullrequestreview-3799718769


More information about the openjfx-dev mailing list