RFR: 8377427: Reduce substring allocations in Color.web(String, double) [v7]

Michael Strauß mstrauss at openjdk.org
Tue Feb 17 19:52:05 UTC 2026


On Tue, 17 Feb 2026 18:17:12 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review comment
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/css/parser/CssNumberParser.java line 34:
> 
>> 32:     private CssNumberParser() {}
>> 33: 
>> 34:     // Up to 19 decimal digits fit in an unsigned 64-bit long
> 
> do we need to parse all 19 digits?  An IEEE 64-bit double has 52 bits of mantissa, which translates into 2^53 = 9007199254740992 (length=16)

We parse all digits that can fit in a `long` because that's what the algorithm processes. Why would we parse less?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2069#discussion_r2818782682


More information about the openjfx-dev mailing list