RFR: 8357625: Build should generate platform specific shaders [v5]
Kevin Rushforth
kcr at openjdk.org
Thu Feb 19 16:15:43 UTC 2026
On Wed, 18 Feb 2026 17:46:47 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:
>> On a given platform, the build generates prism and decora shader files for all platforms.
>> Ideally it should generate only the platform specific shader files.
>>
>> Fix:
>> Generate only platform specific hardware shaders.
>> sw pipeline shaders must be generated for all platforms.
>>
>> But the hardware shaders, should be as:
>> 1. Mac platform : metal and es2 shaders
>> 2. Win platform: d3d shaders and if IS_INCLUDE_ES2 is true then es2 shaders as well
>> 3. Linux : only es2 shaders
>>
>> Verification:
>> Verified that the shaders are generated as expected.
>> headul tests pass, apps launch correctly.
>
> Ambarish Rapte has updated the pull request incrementally with one additional commit since the last revision:
>
> update comment
build.gradle line 1718:
> 1716: doFirst {
> 1717: if (IS_MAC) {
> 1718: mkdir "$project.buildDir/gensrc/mtl-headers"
Will making this optional cause the same problem for Eclipse on non-macOS platforms as the one @andy-goryachev-oracle reported for the Windows dir on non-Windows platforms?
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2071#discussion_r2828767745
More information about the openjfx-dev
mailing list