RFR: 8377427: Reduce substring allocations in Color.web(String, double) [v10]
Michael Strauß
mstrauss at openjdk.org
Thu Feb 19 17:30:55 UTC 2026
On Thu, 19 Feb 2026 17:11:26 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
>> Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:
>>
>> add test
>
> modules/javafx.graphics/src/test/java/test/com/sun/javafx/css/parser/CssNumberParserTest.java line 234:
>
>> 232: double expected = Double.parseDouble(number);
>> 233: double actual = parseDouble(number);
>> 234: assertEquals(Double.doubleToRawLongBits(expected), Double.doubleToRawLongBits(actual));
>
> would it be possible in these fuzzing tests (which are great, by the way!) add a check for a few values adjacent to each point (i.e. +1 ulp, +2 ulp, -1 ulp, -2 ulp)?
For what purpose? The numbers are already random, adding or subtracting a bit doesn't change that.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2069#discussion_r2829166658
More information about the openjfx-dev
mailing list