RFR: 8377427: Reduce substring allocations in Color.web(String, double) [v10]
Andy Goryachev
angorya at openjdk.org
Thu Feb 19 19:15:33 UTC 2026
On Thu, 19 Feb 2026 19:05:11 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:
>> you are right. do you think it would make sense to point to the code (test) that generates the table in the comment?
>
> It seems unusual to point to tests from production code. In any case, we've now locked down the table, and any change will fail the test.
yeah, I wasn't sure myself. one one hand, you are right - it is unusual, on the other, there is absolutely no link to the code that generates the table (which is important for code review purposes).
even worse, the test accesses the field via reflection. I know we don't have an annotation to signify the fact that the name is important, but I feel like a comment pointing to the test and access via reflection might be warranted.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2069#discussion_r2829691545
More information about the openjfx-dev
mailing list