RFR: 8377427: Reduce substring allocations in Color.web(String, double) [v10]
Michael Strauß
mstrauss at openjdk.org
Thu Feb 19 19:15:35 UTC 2026
On Thu, 19 Feb 2026 18:52:09 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
>> For what purpose? The numbers are already random, adding or subtracting a bit doesn't change that.
>
> to ensure the behavior of adjacent values, as it is not covered just by the random numbers (what is the probability of selecting two adjacent random values?)
Hmm... but why? It seems to me that you're suggesting to test some kind of edge case, but I don't understand what the significance of closely adjacent values is in this test. In this test, we parse random number strings with both algorithms, and compare their bitwise equivalence. Since the numbers were random to begin with, a number right next to it is equally random. I don't think this adds any relevant test coverage.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2069#discussion_r2829689631
More information about the openjfx-dev
mailing list