RFR: 8372415: Stage size should match visual window bounds [v6]

Martin Fox mfox at openjdk.org
Thu Feb 19 20:57:06 UTC 2026


On Thu, 19 Feb 2026 18:45:55 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:

> I don't understand what you're suggesting. Are you talking about `WM_GETMINMAXINFO`?

Yes. The code retrieves the shadow and extended rects and computes the difference between them in _setBounds, WM_GETMINMAXINFO, and HandleWindowPosChanging and there are a couple places where those differences are used to convert from one rect to another using similar blocks of code. In _setBounds the min and max are applied to the extended rect which is obviously correct but in WM_GETMINMAXINFO I actually have to think about what you're doing which isn't complicated but, well, I'm not a patient person (mea culpa). It's possible that these similarities are superficial and it's not worth gathering them into a helper object or helper routines but at first blush it looks like I'm reviewing the same code multiple times and figuring out which direction it's going each time.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1982#issuecomment-3929949715


More information about the openjfx-dev mailing list