RFR: 8377427: Reduce substring allocations in Color.web(String, double) [v16]
Michael Strauß
mstrauss at openjdk.org
Wed Feb 25 11:30:07 UTC 2026
On Tue, 24 Feb 2026 22:45:11 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:
>> Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:
>>
>> review comment
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/css/parser/CssNumberParser.java line 236:
>
>> 234: // Subnormals (lines 11-15)
>> 235: if (p <= -1022) {
>> 236: m >>>= -1022 - p;
>
> Did a `p + 1` get dropped here?
Yes. The +1 leads to incorrect results, this might be a typo in the original paper.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2069#discussion_r2850100604
More information about the openjfx-dev
mailing list