RFR: 8342733: Remove references to compiler flags /D_STATIC_CPPLIB and /D_DISABLE_DEPRECATE_STATIC_CPPLIB in win.gradle
Joeri Sykora
sykora at openjdk.org
Fri Feb 27 08:24:37 UTC 2026
On Sun, 22 Feb 2026 03:32:15 GMT, Anirvan Sarkar <asarkar at openjdk.org> wrote:
> The flags /D_STATIC_CPPLIB and /D_DISABLE_DEPRECATE_STATIC_CPPLIB were required on Visual Studio 2010 to avoid bundling msvcp*.dll. These flags do not work since Visual Studio 2012.
>
> These flags are initially added to common set of Visual Studio compiler flags when JavaFX is built.
>
> Before JDK-8289174, these flags were then removed if JavaFX is built on Visual Studio 2010.
> After JDK-8289174, these flags are always removed when JavaFX is built.
>
> As the addition and removal of these flags are now effectively no-op, references to these flags can be removed.
I had no issues during compilation and the changes look good to me.
-------------
Marked as reviewed by sykora (Author).
PR Review: https://git.openjdk.org/jfx/pull/2083#pullrequestreview-3865633255
More information about the openjfx-dev
mailing list