RFR: 8374035: RichTextArea: add insertStyles property

Lukasz Kostyra lkostyra at openjdk.org
Mon Jan 5 14:42:51 UTC 2026


On Tue, 23 Dec 2025 16:51:31 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

> # Use Case
> 
> typing into RichTextArea with a default model (or any other model that supports discrete styles), in the presence of a tool bar or similar UI that allows to specify the styles to take effect on the next key press.  Example:
> - open MS Word or another rich text editor such as TextEdit
> - type something
> - place cursor at the middle of the typed text and hit command-B or ctrl-B on Win/Linux
> - notice how the formatting toolbar highlights [b] button indicating that the style for next character to be inserted has changed to bold
> - type something and confirm that inserted text is bold
> the new style is captured only in the toolbar UI, so clicking on some other part of the text reverts the bold button to the unselected state.
> 
> 
> # Problem
>  
> typing a character uses the model's logic to deal with the styles, via StyledTextModel::replace(StyleResolver resolver, TextPos start, TextPos end, String text) method, see RichTextAreaBehavior::handleTypedChar().  This worked well initially, however it makes it impossible (without extending RichTextAreaBehavior which is not a public class) to implement the behavior described earlier.
> 
> 
> # Solution
> 
> - add 'insertStyles<StyleAttributeMap>' property to the RichTextArea, which will override the model styles in RichTextAreaBehavior::handleTypedChar() if the value is not null

Took a first look at this, this looks good but I have trouble verifying this. The tests work but I also wanted to do some manual testing, I'm following the steps in the issue description using RichEditorDemo and the behavior seems the same with and without this change. Should this have any effect on our existing demos?

-------------

PR Review: https://git.openjdk.org/jfx/pull/2017#pullrequestreview-3627121103


More information about the openjfx-dev mailing list