Integrated: 8366739: ToolBar: overflow menu with fractional scale (2)
Cormac Redmond
duke at openjdk.org
Mon Jan 5 23:43:15 UTC 2026
On Sun, 21 Dec 2025 02:42:12 GMT, Cormac Redmond <duke at openjdk.org> wrote:
> Fix overflow menu triggering due to floating-point precision error.
>
> At 1.25 display scaling on Windows, floating-point comparison errors (e.g. 109.60000000000001 > 109.6) cause the overflow menu to appear when the lefthand value is regarded as larger than the righthand value.
>
> These should be treated as equal (and therefore not display the overflow menu).
>
> This bug can happen in both horizontal and vertical toolbar orientation.
>
> The new tests added fail without this fix, and pass with it. An existing test has been re-factored slightly to allow re-use and more flexibility in specifying the scene's root node.
This pull request has now been integrated.
Changeset: 5b97edf6
Author: Cormac Redmond <credmond at certak.com>
Committer: Andy Goryachev <angorya at openjdk.org>
URL: https://git.openjdk.org/jfx/commit/5b97edf636a5e1f2db6c8f5484df01aef6009d29
Stats: 81 lines in 2 files changed: 46 ins; 10 del; 25 mod
8366739: ToolBar: overflow menu with fractional scale (2)
Reviewed-by: jhendrikx, angorya, mhanl
-------------
PR: https://git.openjdk.org/jfx/pull/2016
More information about the openjfx-dev
mailing list