RFR: 8366739: ToolBar: overflow menu with fractional scale (2)

[Cormac Redmond]

On Mon, 5 Jan 2026 23:50:45 GMT, Cormac Redmond <duke at openjdk.org> wrote:

>>> becoming an [Author](https://openjdk.org/bylaws#author)
>> 
>> also good :-)
>
> Thanks, @andy-goryachev-oracle

> @credmond I noticed after this PR was integrated that you didn't have GitHub Actions enabled for your personal fork of the jfx repo. Fortunately, our CI build that was triggered by the integration passes. If you plan to submit any more PRs, please enable GitHub Actions workflows for your personal fork.
> 
> @andy-goryachev-oracle @hjohn @Maran23 We should let this be a reminder to us to check that a GHA test build was run before approving a PR.

Will do next time, @kevinrushforth. It was indeed disabled:

<img width="757" height="324" alt="image" src="https://github.com/user-attachments/assets/f4080156-afbc-4fd0-8d44-d72540398be2" />.

I didn't realise this was a requirement, or that it would even work E.g., often forked repo workflows fail due to missing secrets/variables or self-hosted runners, etc.

It might be worth mentioning this requirement here:

- https://github.com/openjdk/jfx/blob/master/CONTRIBUTING.md

Running the GHA invoked tests is mentioned here https://github.com/openjdk/jfx/blob/master/README-code-reviews.md:

> Make sure that the PR has executed the GitHub Actions (GHA) tests; if they aren't being run, ask the PR author to enable GHA workflows;

...but that's aimed for reviewers, not contributors, and could be missed.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/2016#issuecomment-3714952038