RFR: 8366739: ToolBar: overflow menu with fractional scale (2)
Kevin Rushforth
kcr at openjdk.org
Tue Jan 6 15:48:01 UTC 2026
On Tue, 6 Jan 2026 14:31:53 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>>> @andy-goryachev-oracle @hjohn @Maran23 We should let this be a reminder to us to check that a GHA test build was run before approving a PR.
>>
>> Thanks for the ping, yes that makes sense, we should all have an eye on that.
>> I was assuming that this is always turned on by default. Note for all others: The 'Checks' Tab always shows a 1 if GHA is not enabled (jcheck) and a 6 if it is.
>
>> Note for all others: The 'Checks' Tab always shows a 1 if GHA is not enabled (jcheck) and a 6 if it is.
>
> Yes, that is the easiest way to tell (and is how I eventually noticed).
> @kevinrushforth maybe the bot can add another check for that or label?
A check that warns if GHA is not enabled seems like a reasonable idea. I'll file an RFE for the Skara bot, although I don't know how soon such a check might be done.
-------------
PR Comment: https://git.openjdk.org/jfx/pull/2016#issuecomment-3715199887
More information about the openjfx-dev
mailing list