RFR: 8374347: StyleAttributeMap.Builder.setParagraphDirection() [v2]

Kevin Rushforth kcr at openjdk.org
Tue Jan 6 20:29:08 UTC 2026


On Tue, 6 Jan 2026 17:22:51 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Renaming `setRTL(ParagraphDirection)` ->  `setParagraphDirection(ParagraphDirection)` in the `StyleAttributeMap.Builder` class.
>> 
>> This is a breaking change with low impact, ok since the feature is still incubating.
>
> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - 2026
>  - Merge branch 'master' into 8374347.paragraph.direction
>  - set paragraph direction

The API change looks good. I see that there is no caller of this method. Is adding a test for this already covered by one of the existing test bugs? If not, please file an issue or update an existing one to cover the addition of such a test.

-------------

Marked as reviewed by kcr (Lead).

PR Review: https://git.openjdk.org/jfx/pull/2021#pullrequestreview-3632376274


More information about the openjfx-dev mailing list