RFR: 8374035: RichTextArea: add insertStyles property [v2]

Andy Goryachev angorya at openjdk.org
Tue Jan 6 21:07:40 UTC 2026


On Tue, 6 Jan 2026 19:23:15 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
>> 
>>  - 2026
>>  - Merge branch 'master' into 8374035.insert.styles
>>  - test
>>  - 26
>>  - Merge branch 'master' into 8374035.insert.styles
>>  - Merge branch 'master' into 8374035.insert.styles
>>  - insert styles
>
> modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/RichTextArea.java line 600:
> 
>> 598:     /**
>> 599:      * Specifies the styles to be in effect for the characters to be inserted via user input.
>> 600:      * The value can be null.
> 
> Can you document the behavior when this is null? Looking at the implementation, I think it takes the style at the caret position, but would be helpful to specify (also say whether there is a different depending on whether the caret is leading or trailing).

updated the javadoc, should be clear now.
the leading/trailing caret is irrelevant in this case, as it's determined by the model.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2017#discussion_r2666283596


More information about the openjfx-dev mailing list