RFR: 8366739: ToolBar: overflow menu with fractional scale (2) [v5]

[Kevin Rushforth]

On Tue, 23 Dec 2025 14:39:21 GMT, Cormac Redmond <duke at openjdk.org> wrote:

>> Fix overflow menu triggering due to floating-point precision error.
>> 
>> At 1.25 display scaling on Windows, floating-point comparison errors (e.g. 109.60000000000001 > 109.6) cause the overflow menu to appear when the lefthand value is regarded as larger than the righthand value.
>> 
>> These should be treated as equal (and therefore not display the overflow menu).
>> 
>> This bug can happen in both horizontal and vertical toolbar orientation.
>> 
>> The new tests added fail without this fix, and pass with it. An existing test has been re-factored slightly to allow re-use and more flexibility in specifying the scene's root node.
>
> Cormac Redmond has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8366739: remove pointless re-assignment of length

I filed the following two JBS issues:

[SKARA-2647](https://bugs.openjdk.org/browse/SKARA-2647): Skara's PR checks should warn if GHA workflows are not enabled in fork

[JDK-8374655](https://bugs.openjdk.org/browse/JDK-8374655): Update CONTRIBUTING.md to ask PR authors to enable GHA in their repo

-------------

PR Comment: https://git.openjdk.org/jfx/pull/2016#issuecomment-3716705747