RFR: 8374347: StyleAttributeMap.Builder.setParagraphDirection() [v2]
Lukasz Kostyra
lkostyra at openjdk.org
Wed Jan 7 07:51:12 UTC 2026
On Tue, 6 Jan 2026 17:22:51 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
>> Renaming `setRTL(ParagraphDirection)` -> `setParagraphDirection(ParagraphDirection)` in the `StyleAttributeMap.Builder` class.
>>
>> This is a breaking change with low impact, ok since the feature is still incubating.
>
> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>
> - 2026
> - Merge branch 'master' into 8374347.paragraph.direction
> - set paragraph direction
LGTM, quick confidence build and test run works fine. This was not used anywhere in our internal code and the feature is incubating so it's fine to rename.
-------------
Marked as reviewed by lkostyra (Reviewer).
PR Review: https://git.openjdk.org/jfx/pull/2021#pullrequestreview-3633709254
More information about the openjfx-dev
mailing list