RFR: 8370498: Improve how Node detects whether a layout property change requires a new layout pass [v4]

Andy Goryachev angorya at openjdk.org
Wed Jan 7 21:06:18 UTC 2026


On Mon, 27 Oct 2025 14:44:44 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

>> This new check is much more accurate to detect whether a parent is currently laying out its children. The previous code almost never worked, resulting in additional unnecessary layouts.
>
> John Hendrikx has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Rename test

To add to an earlier discussion regarding the number of iterations required for the layout to converge: there are situations where the layout goes into infinite update mode - I've seen these back in java 8 fx days, and it might happen even today.

Below is an example I captured with the monkey tester on 2025/12/03 using the current the master branch of that day:


https://github.com/user-attachments/assets/1a4cd2d5-4b71-4f25-b43b-287f22f10f82

The video could not capture the flicker exactly probably due to capture limitations, but the flicker continued until the user clicks on something or resizes the window.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1945#issuecomment-3720788832


More information about the openjfx-dev mailing list