RFR: 8371067: RichTextArea: requestLayout by inline node doesn't reach VFlow [v7]

Andy Goryachev angorya at openjdk.org
Mon Jan 12 15:38:14 UTC 2026


On Mon, 12 Jan 2026 05:42:13 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   2026
>
> modules/jfx.incubator.richtext/src/main/java/com/sun/jfx/incubator/scene/control/richtext/util/RichUtils.java line 767:
> 
>> 765:                 }
>> 766:             }
>> 767:             return null;
> 
> It seems this if condition would never be true in current situation, and very likely be never true in future in context of RTA. A VFlow cannot be Window.
> Can this code be removed ? keeping only the required else block.

You are right.  This implementation was taken from another project I have that ensures that the right parent is returned, but in this particular case the `Window`- and `Menu`- specific code paths can be removed.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1975#discussion_r2682803068


More information about the openjfx-dev mailing list