RFR: 8375016: Several catch blocks for NullPointerExceptions exist in the codebase [v2]
Kevin Rushforth
kcr at openjdk.org
Tue Jan 13 00:02:49 UTC 2026
On Mon, 12 Jan 2026 19:37:57 GMT, Christopher Schnick <duke at openjdk.org> wrote:
>> This PR replaces various catch blocks for NPEs by proper null checks. It looks like a lot but most of the binding changes are just variants of the same approach. The test cases have been adapted to not check for NPEs anymore.
>>
>> The PrismFontFactory change to a RuntimeException was made because I don't see how the try block can throw an NPE.
>
> Christopher Schnick has updated the pull request incrementally with two additional commits since the last revision:
>
> - Fix visibility
> - Fixes
This will need careful review, and probably additional tests, to ensure that there are no regressions or changes in behavior.
We will need to run it through our headful test system as well, since headless sanity testing is not going to be sufficient here.
This isn't something I want to do quickly, so this will need to wait until after the jfx26 fork and we have sufficient time to test it.
-------------
PR Comment: https://git.openjdk.org/jfx/pull/2032#issuecomment-3741067839
More information about the openjfx-dev
mailing list