RFR: 8375016: Several catch blocks for NullPointerExceptions exist in the codebase
Kevin Rushforth
kcr at openjdk.org
Wed Jan 14 19:50:34 UTC 2026
On Mon, 12 Jan 2026 17:45:43 GMT, Christopher Schnick <duke at openjdk.org> wrote:
>> This PR replaces various catch blocks for NPEs by proper null checks. It looks like a lot but most of the binding changes are just variants of the same approach. The test cases have been adapted to not check for NPEs anymore.
>>
>> The PrismFontFactory change to a RuntimeException was made because I don't see how the try block can throw an NPE.
>
> Well that depends on what serious means here. I would consider it serious, so I am moving it to a draft to figure out how to retain the exact behaviour of the old implementation
@crschnick As I mentioned above, I don't want to rush this in. Please wait until after tomorrow's jfx26 fork to integrate it, even if there is a second approving reviewer.
-------------
PR Comment: https://git.openjdk.org/jfx/pull/2032#issuecomment-3751337567
More information about the openjfx-dev
mailing list