RFR: 8375227: Silent OOBE in NGGroup::renderContent [v2]

Andy Goryachev angorya at openjdk.org
Wed Jan 14 22:57:48 UTC 2026


On Wed, 14 Jan 2026 21:57:14 GMT, Christopher Schnick <duke at openjdk.org> wrote:

>> This is a very basic solution to the OOBE described in the issue. While it would definitely be better to figure out the root cause, understanding the NGNode implementation is above my knowledge level atm.
>> 
>> The code has been like that for 10 years and no one complained, so I am not sure whether this is a deeper issue or just a small oversight when handling all possible cases.
>> 
>> The fix should retain the exact original workings of the method while avoiding the exception.
>
> Christopher Schnick has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Wrap expression in parentheses

Marked as reviewed by angorya (Reviewer).

The original code was just not right, failing to account for a specific case when
`orderedChildren` array does not contain `renderRoot.getCurrentNode()` in line 248

there seems to be no ill effects since 2016 (or 2012 when the code was initially open sourced).

-------------

PR Review: https://git.openjdk.org/jfx/pull/2037#pullrequestreview-3663203027
PR Comment: https://git.openjdk.org/jfx/pull/2037#issuecomment-3752075773


More information about the openjfx-dev mailing list