RFR: 8375227: Silent OOBE in NGGroup::renderContent [v2]
Christopher Schnick
duke at openjdk.org
Thu Jan 15 02:00:41 UTC 2026
On Thu, 15 Jan 2026 00:06:12 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:
>> Christopher Schnick has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Wrap expression in parentheses
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/sg/prism/NGGroup.java line 259:
>
>> 257: NGNode child;
>> 258: try {
>> 259: child = orderedChildren.get(i);
>
> You should remove the try-catch block as your change ensures that `List.get()` is never called with an invalid index.
Judging from the comment below, the catch block was mainly meant to handle concurrent modifications of the list. That scenario might still happen
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2037#discussion_r2692676781
More information about the openjfx-dev
mailing list