RFR: 8375444: MenuButton - textTruncated Property is always false [v2]
Andy Goryachev
angorya at openjdk.org
Thu Jan 15 18:28:21 UTC 2026
On Thu, 15 Jan 2026 18:12:13 GMT, Florian Kirmaier <fkirmaier at openjdk.org> wrote:
>> For MenuButton and SplitMenuButton the textTruncated Property is always false - but the text is correctly rendered truncated if it is to long.
>>
>> This PR fixes it, by extending the logic in LabeledImpl - to always forward this property.
>> I've also extended the existing tests for the truncated property.
>>
>> It would be great, to get some feedback on how i fixes the bug.
>
> Florian Kirmaier has updated the pull request incrementally with one additional commit since the last revision:
>
> JDK-8375444
> Small code formatting fixes
Marked as reviewed by angorya (Reviewer).
modules/javafx.controls/src/test/java/test/javafx/scene/control/LabeledTruncatedTest.java line 122:
> 120: testWithSkin(fun.get());
> 121: testTextProperty(fun.get());
> 122:
extra newline? sorry, missed it earlier
-------------
PR Review: https://git.openjdk.org/jfx/pull/2040#pullrequestreview-3666994923
PR Review Comment: https://git.openjdk.org/jfx/pull/2040#discussion_r2695489180
More information about the openjfx-dev
mailing list