RFR: 8375561: Class NGGroup is in need of some cleanup
Christopher Schnick
duke at openjdk.org
Fri Jan 16 19:15:12 UTC 2026
On Fri, 16 Jan 2026 18:58:45 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> This should improve the code quality of the class while preserving its original workings
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/sg/prism/NGGroup.java line 221:
>
>> 219: List<NGNode> orderedChildren = getOrderedChildren();
>> 220: for (NGNode orderedChild : orderedChildren) {
>> 221: orderedChild.renderForcedContent(gOptional);
>
> If `getOrderedChildren()` can ever return null, then the null check is needed, so I can't tell without digging a little whether this is a safe fix.
Should I add the explanations in the PR or the JBS issue? Andy also asked for a summary in the JBS issue, so ideally I would combine that
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2043#discussion_r2699670793
More information about the openjfx-dev
mailing list