RFR: 8375561: Class NGGroup is in need of some cleanup [v2]

Andy Goryachev angorya at openjdk.org
Fri Jan 16 22:32:59 UTC 2026


On Fri, 16 Jan 2026 22:25:29 GMT, Christopher Schnick <duke at openjdk.org> wrote:

>> This should improve the code quality of the class while preserving its original workings
>
> Christopher Schnick has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - Remove space
>  - Use for loops again
>  - Remove unused method

modules/javafx.graphics/src/main/java/com/sun/javafx/sg/prism/NGGroup.java line 265:

> 263:                     child = null;
> 264:                 }
> 265:                 // minimal protection against concurrent update of the list.

see, this is a worrisome comment - and perhaps the value of this PR would be much higher if you can demonstrate that the concurrency is not an issue.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2043#discussion_r2700188133


More information about the openjfx-dev mailing list