RFR: 8375561: Class NGGroup is in need of some cleanup [v2]

Michael Strauß mstrauss at openjdk.org
Tue Jan 20 17:38:10 UTC 2026


On Fri, 16 Jan 2026 22:25:29 GMT, Christopher Schnick <duke at openjdk.org> wrote:

>> This should improve the code quality of the class while preserving its original workings
>
> Christopher Schnick has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - Remove space
>  - Use for loops again
>  - Remove unused method

modules/javafx.graphics/src/main/java/com/sun/javafx/sg/prism/NGGroup.java line 212:

> 210:      * @param blendMode cannot be null
> 211:      */
> 212:     public void setBlendMode(Object blendMode) {

It seems like group blend modes were [removed](https://bugs.openjdk.org/browse/JDK-8113442) a long time ago. You should also delete all of the implementation, not only the setter here.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2043#discussion_r2709392547


More information about the openjfx-dev mailing list